placesview: Remove event box usage
authorBenjamin Otte <otte@redhat.com>
Wed, 2 Aug 2017 11:12:58 +0000 (12:12 +0100)
committerBenjamin Otte <otte@redhat.com>
Wed, 2 Aug 2017 13:05:02 +0000 (14:05 +0100)
gtk/gtkplacesview.c
gtk/gtkplacesviewrow.c
gtk/gtkplacesviewrowprivate.h
gtk/ui/gtkplacesviewrow.ui

index e526e6df67eeaf0b611d68a98505416e9ff9e8b1..9599bbeb0678638bfdd9a9e43d13e61104c035f4 100644 (file)
@@ -671,7 +671,7 @@ insert_row (GtkPlacesView *view,
 
   g_object_set_data (G_OBJECT (row), "is-network", GINT_TO_POINTER (is_network));
 
-  g_signal_connect_swapped (gtk_places_view_row_get_event_box (GTK_PLACES_VIEW_ROW (row)),
+  g_signal_connect_swapped (GTK_PLACES_VIEW_ROW (row),
                             "button-press-event",
                             G_CALLBACK (on_button_press_event),
                             row);
index 61dd1f53890565337f7d77d0ca969b63c603c204..eb00df786711954a598646859b7fe68143bf521f 100644 (file)
@@ -48,7 +48,6 @@ struct _GtkPlacesViewRow
   GtkSpinner    *busy_spinner;
   GtkButton     *eject_button;
   GtkImage      *eject_icon;
-  GtkEventBox   *event_box;
   GtkImage      *icon_image;
   GtkLabel      *name_label;
   GtkLabel      *path_label;
@@ -382,7 +381,6 @@ gtk_places_view_row_class_init (GtkPlacesViewRowClass *klass)
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, busy_spinner);
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, eject_button);
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, eject_icon);
-  gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, event_box);
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, icon_image);
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, name_label);
   gtk_widget_class_bind_template_child (widget_class, GtkPlacesViewRow, path_label);
@@ -436,14 +434,6 @@ gtk_places_view_row_get_eject_button (GtkPlacesViewRow *row)
   return GTK_WIDGET (row->eject_button);
 }
 
-GtkWidget*
-gtk_places_view_row_get_event_box (GtkPlacesViewRow *row)
-{
-  g_return_val_if_fail (GTK_IS_PLACES_VIEW_ROW (row), NULL);
-
-  return GTK_WIDGET (row->event_box);
-}
-
 void
 gtk_places_view_row_set_busy (GtkPlacesViewRow *row,
                               gboolean          is_busy)
index 24e39d5563cf0b7e23de930ec4e35d4b3d85cdd7..ad913275a1b9ec736251689bda929430e5bb5a31 100644 (file)
@@ -38,8 +38,6 @@ GtkWidget*         gtk_places_view_row_new                       (GVolume
 
 GtkWidget*         gtk_places_view_row_get_eject_button          (GtkPlacesViewRow   *row);
 
-GtkWidget*         gtk_places_view_row_get_event_box             (GtkPlacesViewRow   *row);
-
 GMount*            gtk_places_view_row_get_mount                 (GtkPlacesViewRow   *row);
 
 GVolume*           gtk_places_view_row_get_volume                (GtkPlacesViewRow   *row);
index 3b44e6d55eb6a6ea84e36710745fc3dc77bdb19a..69b5dfd70868a1d0f5314568eb8f5e588588ce82 100644 (file)
@@ -6,97 +6,92 @@
     <property name="visible">True</property>
     <property name="can-focus">True</property>
     <child>
-      <object class="GtkEventBox" id="event_box">
+      <object class="GtkBox" id="box">
         <property name="visible">1</property>
+        <property name="margin-start">12</property>
+        <property name="margin-end">12</property>
+        <property name="margin-top">6</property>
+        <property name="margin-bottom">6</property>
+        <property name="spacing">18</property>
         <child>
-          <object class="GtkBox" id="box">
+          <object class="GtkImage" id="icon_image">
             <property name="visible">1</property>
-            <property name="margin-start">12</property>
-            <property name="margin-end">12</property>
-            <property name="margin-top">6</property>
-            <property name="margin-bottom">6</property>
-            <property name="spacing">18</property>
-            <child>
-              <object class="GtkImage" id="icon_image">
-                <property name="visible">1</property>
-                <property name="pixel-size">32</property>
-              </object>
-            </child>
-            <child>
-              <object class="GtkLabel" id="name_label">
-                <property name="visible">1</property>
-                <property name="hexpand">1</property>
-                <property name="xalign">0</property>
-                <property name="ellipsize">end</property>
-              </object>
-              <packing>
-                <property name="position">1</property>
-              </packing>
-            </child>
-            <child>
-              <object class="GtkLabel" id="available_space_label">
-                <property name="xalign">1</property>
-                <style>
-                  <class name="dim-label"/>
-                </style>
-              </object>
-              <packing>
-                <property name="position">2</property>
-              </packing>
-            </child>
+            <property name="pixel-size">32</property>
+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="name_label">
+            <property name="visible">1</property>
+            <property name="hexpand">1</property>
+            <property name="xalign">0</property>
+            <property name="ellipsize">end</property>
+          </object>
+          <packing>
+            <property name="position">1</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkLabel" id="available_space_label">
+            <property name="xalign">1</property>
+            <style>
+              <class name="dim-label"/>
+            </style>
+          </object>
+          <packing>
+            <property name="position">2</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkLabel" id="path_label">
+            <property name="visible">1</property>
+            <property name="justify">right</property>
+            <property name="ellipsize">middle</property>
+            <property name="xalign">0</property>
+            <property name="max-width-chars">15</property>
+            <style>
+              <class name="dim-label"/>
+            </style>
+          </object>
+          <packing>
+            <property name="position">3</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkStack" id="mount_stack">
+            <property name="visible">1</property>
+            <property name="hhomogeneous">1</property>
+            <property name="vhomogeneous">1</property>
             <child>
-              <object class="GtkLabel" id="path_label">
-                <property name="visible">1</property>
-                <property name="justify">right</property>
-                <property name="ellipsize">middle</property>
-                <property name="xalign">0</property>
-                <property name="max-width-chars">15</property>
+              <object class="GtkButton" id="eject_button">
+                <property name="visible">0</property>
+                <property name="halign">center</property>
+                <property name="valign">center</property>
+                <property name="tooltip-text" translatable="yes">Unmount</property>
+                <child>
+                  <object class="GtkImage" id="eject_icon">
+                    <property name="visible">1</property>
+                    <property name="icon-name">media-eject-symbolic</property>
+                    <property name="icon-size">1</property>
+                  </object>
+                </child>
                 <style>
-                  <class name="dim-label"/>
+                  <class name="image-button"/>
+                  <class name="sidebar-button"/>
                 </style>
               </object>
-              <packing>
-                <property name="position">3</property>
-              </packing>
             </child>
             <child>
-              <object class="GtkStack" id="mount_stack">
+              <object class="GtkSpinner" id="busy_spinner">
                 <property name="visible">1</property>
-                <property name="hhomogeneous">1</property>
-                <property name="vhomogeneous">1</property>
-                <child>
-                  <object class="GtkButton" id="eject_button">
-                    <property name="visible">0</property>
-                    <property name="halign">center</property>
-                    <property name="valign">center</property>
-                    <property name="tooltip-text" translatable="yes">Unmount</property>
-                    <child>
-                      <object class="GtkImage" id="eject_icon">
-                        <property name="visible">1</property>
-                        <property name="icon-name">media-eject-symbolic</property>
-                        <property name="icon-size">1</property>
-                      </object>
-                    </child>
-                    <style>
-                      <class name="image-button"/>
-                      <class name="sidebar-button"/>
-                    </style>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkSpinner" id="busy_spinner">
-                    <property name="visible">1</property>
-                    <property name="active">1</property>
-                    <property name="halign">center</property>
-                    <property name="valign">center</property>
-                  </object>
-                </child>
+                <property name="active">1</property>
+                <property name="halign">center</property>
+                <property name="valign">center</property>
               </object>
-              <packing>
-                <property name="position">4</property>
-              </packing>
             </child>
           </object>
+          <packing>
+            <property name="position">4</property>
+          </packing>
         </child>
       </object>
     </child>